Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: 80.0 -> 80.0.1 #97105

Merged
merged 1 commit into from Sep 7, 2020
Merged

firefox-bin: 80.0 -> 80.0.1 #97105

merged 1 commit into from Sep 7, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 4, 2020

Motivation for this change

https://www.mozilla.org/en-US/firefox/80.0.1/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Atemu
Atemu approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 97105 1

4 packages built:
- dropbox
- dropbox-cli
- firefox-bin-unwrapped
- mate.caja-dropbox

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/216

@AndersonTorres AndersonTorres merged commit 03c2ba6 into NixOS:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stigtsp @nixos-discourse @Atemu @AndersonTorres