Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 80.0 -> 80.0.1 #97106

Merged
merged 1 commit into from Sep 6, 2020
Merged

firefox: 80.0 -> 80.0.1 #97106

merged 1 commit into from Sep 6, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Sep 4, 2020 •
edited by vcunat

Motivation for this change

https://www.mozilla.org/en-US/firefox/80.0.1/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp marked this pull request as draft September 4, 2020 10:45
@stigtsp
Copy link
Member Author

stigtsp commented Sep 4, 2020 •
edited

Waiting for local build + test

@ofborg ofborg bot requested review from edolstra and andir September 4, 2020 11:29
@stigtsp stigtsp marked this pull request as ready for review September 4, 2020 16:17
vcunat
vcunat approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work OK for me.

@Atemu
Copy link
Member

Atemu commented Sep 6, 2020

Result of nixpkgs-review pr 97106 1

3 packages built:
- adoptopenjdk-icedtea-web
- xulrunner (firefox-unwrapped)
- slimerjs

LGTM

@andir andir merged commit 8cf4c19 into NixOS:master Sep 6, 2020
@ajs124 ajs124 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stigtsp @Atemu @ajs124 @vcunat @andir