Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #235

Merged
merged 7 commits into from Aug 4, 2021
Merged

minor improvements #235

merged 7 commits into from Aug 4, 2021

Conversation

DerDakon
Copy link
Contributor

@DerDakon DerDakon commented Sep 4, 2020

Just some things I came accross while hacking on some custom ELF manipulations.

../../patchelf/src/patchelf.cc:835:19: warning: comparison of integer expressions of different signedness: 'long long unsigned int' and 'off_t' {aka 'long long int'} [-Wsign-compare]
  835 |     assert(curOff == startOffset + neededSpace);
      |            ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
@domenkozar domenkozar merged commit add92c1 into NixOS:master Aug 4, 2021
@DerDakon DerDakon deleted the cleanups branch August 4, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants