Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.catalogue: Remove dubplicate argument pytestCheckHook #97076

Merged
merged 1 commit into from Sep 4, 2020
Merged

python.pkgs.catalogue: Remove dubplicate argument pytestCheckHook #97076

merged 1 commit into from Sep 4, 2020

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Fix staging evaluation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar referenced this pull request Sep 4, 2020
@FRidh
python3Packages.catalouge: fix tests
aee512f
@FRidh FRidh merged commit a92005b into NixOS:staging Sep 4, 2020
@jonringer
Copy link
Contributor

duplicate of #97050 guess I should have just merged mine 9 hours ago...

@doronbehar doronbehar deleted the pkg/python/catalogue branch March 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @jonringer @FRidh