Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kopia: 0.6.2 -> 0.6.4 #97077

Merged
merged 1 commit into from Sep 14, 2020
Merged

kopia: 0.6.2 -> 0.6.4 #97077

merged 1 commit into from Sep 14, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/qz62r723lgw0k2xcv2lh5nk3z08y3hhm-kopia-0.6.2 59.9M
/nix/store/lgm45j3y78l1r2si7rash3j56zyl9h9h-kopia-0.6.4 59.9M

@ofborg ofborg bot requested a review from kalbasit September 4, 2020 05:18
@risicle
Copy link
Contributor

risicle commented Sep 4, 2020 •
edited

Fails to build for me on macos 10.14:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/yaxa64m21z0jy1cg0d6allml7z7w2lnj-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
mv: cannot move 'tmp-vendor' to 'vendor': Permission denied

Edit: ah but I notice it previously failed with the same error anyway, so 🤷

risicle
risicle approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs for me non-nixos linux x86_64

@marsam marsam merged commit 985530f into NixOS:master Sep 14, 2020
@bbigras bbigras deleted the kopia branch September 14, 2020 03:15
@bbigras
Copy link
Contributor Author

bbigras commented Sep 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @risicle @marsam