Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.ghcide: Fix build #97052

Merged
merged 2 commits into from Sep 4, 2020
Merged

haskellPackages.ghcide: Fix build #97052

merged 2 commits into from Sep 4, 2020

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Sep 3, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout
cdepillabout approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get a comment on why the fetchpatch is needed, but other than that this LGTM

@maralorn
Copy link
Member Author

maralorn commented Sep 4, 2020

btw. I want to try out to not force push a single commit again and again in a PR. I think it is much better to only rebase on merge conflicts and otherwise make a squash commit on merge.

@maralorn maralorn merged commit 037e178 into NixOS:haskell-updates Sep 4, 2020
@maralorn maralorn deleted the fix-ghcide branch September 4, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout