Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: [Actions] export eints to git every night or upon request #11

Closed
wants to merge 1 commit into from

Conversation

TrueBrain
Copy link
Member

This is also the moment it will pick up new strings that might
have been committed.

This has to be committed to master, and not openttd-github, despite it mostly using openttd-github specific files. This seems to have to do with how GitHub works with workflow_dispatch and schedule. I could not get the workflow to show up without committing it to master.

It uses https://github.com/OpenTTD/eints-sandbox for staging and https://github.com/OpenTTD/OpenTTD for production. The latter is currently disabled, as it does not exist yet. This will be fixed in a later Pull Request before going live.


on:
schedule:
- cron: '0 19 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do not know when the nightly runs, and whether it now runs at a fixed UTC time or still changes between CET and CETS.
However, I would expect minute 45 here.

Copy link
Member Author

@TrueBrain TrueBrain Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow schedule runs UTC. Which is different from now, as indeed it currently runs on CE(S)T. I don't see a real solution atm to fix this; guess this will have to do? (I will change it into 45)

@@ -0,0 +1,58 @@
name: Eints to Git

# This script has to be in master, despite the code being executed in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also https://github.com/OpenTTD/workflows
Is that an option?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. But I was thinking it would be wiser to have this as close to the eints repo as possible, as it really is related to eints. But this whole repo with its branches is a bit of an odd duck ofc :) I checked if we can fork a repo inside the same organization, but you cannot. Which is a bit sad, tbh :P Do you prefer it in a completely different repository?

This is also the moment it will pick up new strings that might
have been committed.

Times are in UTC, so it runs at 17:45 UTC, which is either
18:45 CET or 19:45 CEST, which are both before the nightly
(which runs at 19:45 CE(S)T). GitHub Actions currently doesn't
support timezones.
@TrueBrain
Copy link
Member Author

Is now at OpenTTD/workflows#6

@TrueBrain TrueBrain closed this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants