Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc8102Binary: init, enable armv7l #98656

Merged
merged 1 commit into from Sep 25, 2020
Merged

ghc8102Binary: init, enable armv7l #98656

merged 1 commit into from Sep 25, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented Sep 24, 2020

Motivation for this change

Mostly armv7l support. Previous binary releases weren't shipping with armv7l builds.

Diff against 8.6.5-binary.nix - https://gist.github.com/sorki/88930e984b5ca5fa427da87c25933bbb

Tested on x86_64 and armv7l. Currently trying to use it to bootstrap native ghc8102.

I'm not yet sure if LD=ld.gold is needed for aarch64 as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peti
Copy link
Member

peti commented Sep 25, 2020

@GrahamcOfBorg build ghc8102Binary.ghc ghc8102Binary.hscolour

@sorki sorki marked this pull request as ready for review September 25, 2020 19:20
@peti peti merged commit 3913f6a into NixOS:haskell-updates Sep 25, 2020
@peti
Copy link
Member

peti commented Sep 25, 2020

I've tried the build on a Raspberry Pi 4b, aarch64, and it failed with the following error:

utils/ghc-cabal/dist-install/build/tmp/ghc-cabal: error while loading shared libraries: libnuma.so.1: cannot open shared object file: No such file or directory

I'm not sure what libnuma.so.1 is.

@cdepillabout cdepillabout mentioned this pull request Sep 26, 2020
Merged
10 tasks
@sorki
Copy link
Member Author

sorki commented Sep 26, 2020

I've tried the build on a Raspberry Pi 4b, aarch64, and it failed with the following error:

utils/ghc-cabal/dist-install/build/tmp/ghc-cabal: error while loading shared libraries: libnuma.so.1: cannot open shared object file: No such file or directory

I'm not sure what libnuma.so.1 is.

Thanks for testing, I've managed to provision my Pi4 today so I can try as well now (and possibly fix that as it looks like just a missing patchelf bit).

@sorki sorki mentioned this pull request Sep 26, 2020
Merged
10 tasks
@thefloweringash thefloweringash mentioned this pull request Nov 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sorki @peti @doronbehar