[20.09] Build some KDE Applications with Qt 5.15 #98657
Conversation
There was a problem hiding this comment.
all-packages.nix still needs cantata to be updated:
error: while evaluating 'callPackageWith' at /home/jon/.cache/nixpkgs-review/pr-98657/nixpkgs/lib/customisation.nix:117:35, called from /home/jon/.cache/nixpkgs-review/pr-98657/nixpkgs/pkgs/top-level/all-packages.nix:2600:13:
while evaluating 'makeOverridable' at /home/jon/.cache/nixpkgs-review/pr-98657/nixpkgs/lib/customisation.nix:67:24, called from /home/jon/.cache/nixpkgs-review/pr-98657/nixpkgs/lib/customisation.nix:121:8:
anonymous function at /home/jon/.cache/nixpkgs-review/pr-98657/nixpkgs/pkgs/applications/audio/cantata/default.nix:1:1 called with unexpected argument 'vlc', at /home/jon/.cache/nixpkgs-review/pr-98657/nixpkgs/lib/customisation.nix:69:16
|
Needs #98862 |
|
@ttuegel Merged. Please rebase. |
|
@GrahamcOfBorg eval |
ttuegel
force-pushed
the
release-20.09--kde-applications-qt-5.15
branch
from
a649a52
to
38a7ffa
Compare
ttuegel
force-pushed
the
release-20.09--kde-applications-qt-5.15
branch
from
9a38941
to
8209ea2
Compare
|
I did a nixpkgs-review, if this looks right @ttuegel feel free to merge |
|
also used this as a good example to improve nixpkgs-review Mic92/nixpkgs-review#131 |
|
@ttuegel I'm getting the following error after the recent changes to KDE applications: |
|
Why does KDE require multiple versions of Qt? I noticed after rebuilding my system on 20.09 that I now have three different versions of Qt in the system closure, which IMHO is not really an acceptable amount of bloat. Surely upstream KDE is supposed to build against a single version of Qt? |
The basic Plasma installation, including the desktop and base applications like Dolphin and Konsole, depends only on Qt 5.12, which is the latest version that is compatible with Plasma and also in Nixpkgs. Some applications may require a newer version (most notably, the KDE PIM suite) and they get the latest compatible version.
There is no monolithic KDE upstream; there is the Plasma desktop (which we build with a single Qt version) and there are independent applications. Other distros deal with this by building packages with whatever version of Qt is required and dynamically linking at runtime to whatever version of Qt happens to be in
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-should-stable-nixos-prioritize/9646/1 |
|
This will be slightly reverted once #101369 will be backported. EDIT: Slightly. |
|
If it improves the user experience, I'm okay with backporting. I would just like for someone to verify with plasma as their DM, as we've had sever awkward runtime issues in the past |
|
@doronbehar Because @ttuegel is the maintainer of Qt I would only permit a backport if he approves of it. |
Motivation for this change
Some KDE PIM Applications are broken without Qt 5.15.
Fixes #98834
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)