[Gecko Bug 1658702] part 18: Implement the path to compute target ranges when deleting around an invisible <br> element
#25781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound an invisible `<br>` element This patch corresponds to: * https://searchfox.org/mozilla-central/rev/30e70f2fe80c97bfbfcd975e68538cefd7f58b2a/editor/libeditor/HTMLEditSubActionHandler.cpp#3431,3450,3459-3489,3511-3517 However, it seems that this is a dead path in most cases because most tests added by this patch are handled as non-collapsed range deletion. The collapsed range is extended by `AutoRangeArray::ExtendAnchorFocusRangeFor()`. Differential Revision: https://phabricator.services.mozilla.com/D90540 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1658702 gecko-commit: 787fd92f95f65f6e708905dc3532c3e4a4575988 gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch corresponds to:
However, it seems that this is a dead path in most cases because most tests
added by this patch are handled as non-collapsed range deletion. The
collapsed range is extended by
AutoRangeArray::ExtendAnchorFocusRangeFor().Differential Revision: https://phabricator.services.mozilla.com/D90540
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1658702
gecko-commit: 787fd92f95f65f6e708905dc3532c3e4a4575988
gecko-reviewers: m_kato