tlp: Add support for non-x86 platforms #98618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, tlp won't build because it depends on x86_energy_perf_policy which is only available on x86. This commit only relies on x86_energy_perf_policy on systems where it is available, allowing tlp to build on other systems like aarch64-linux.
| ] ++ lib.optional enableRDW networkmanager | ||
| ++ lib.optional (lib.any (lib.meta.platformMatch stdenv.hostPlatform) x86_energy_perf_policy.meta.platforms) x86_energy_perf_policy |
There was a problem hiding this comment.
Why do you need lib.any here? Why not just x86_energy_perf_policy.meta.platforms?
There was a problem hiding this comment.
My intention was to say that if the current platform matches any of the platforms supported by x86_energy_perf_policy, then include it, otherwise don't. So I guess lib.any is there because there are multiple platforms in x86_energy_perf_policy.meta.platforms.
lovesegfault
approved these changes
Sep 26, 2020
|
Pinging @flokli for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, tlp won't build because it depends on
x86_energy_perf_policy which is only available on x86. This commit only
relies on x86_energy_perf_policy on systems where it is available,
allowing tlp to build on other systems like aarch64-linux.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)