dynalist: init at 1.0.5 #98612
Closed
dynalist: init at 1.0.5 #98612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
requested changes
Jan 18, 2021
Comment on lines
+7
to
+12
|
|
||
| let | ||
| electron = electron_4; | ||
|
|
||
| in | ||
|
|
There was a problem hiding this comment.
Suggested change
| let | |
| electron = electron_4; | |
| in |
| version = "1.0.5"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://dynalist.io/standalone/download?file=dynalist.tar.gz"; |
There was a problem hiding this comment.
Please upload the archive to web.archive.org.
| cp -a locales $out/share/${pname} | ||
|
|
||
| # Wrap the application with Electron. | ||
| makeWrapper "${electron}/bin/electron" "$out/bin/${pname}" \ |
There was a problem hiding this comment.
Suggested change
| makeWrapper "${electron}/bin/electron" "$out/bin/${pname}" \ | |
| makeWrapper "${electron_4}/bin/electron" "$out/bin/${pname}" \ |
|
|
||
| passthru.updateScript = ./update.sh; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
| --prefix LD_LIBRARY_PATH : "${stdenv.lib.makeLibraryPath runtimeLibs}" | ||
| ''; | ||
|
|
||
| passthru.updateScript = ./update.sh; |
There was a problem hiding this comment.
There is no update script here.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)