New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use search icon instead of search input box in the navbar #575
Conversation
@samueldr I'm not so sure I did a good job with the flex box, but I got it working on the end. I think you should look at this to make sure I'm not complicating things unnecessary. |
Totally not reviewing the important bits first. When working with the DOM, we are using With this one notable addendum:
It's a bit hard sometimes to distinguish what is a component in our setup. I would argue that, here, the component is the Thus the element would be In the next, and upcoming comment: actually reviewing the meat of the change. |
It's simply impossible to use `:extend` with media queries. This is because the rules are defined for a different media query! As LESS *only* appends selectors to the other one, it doesn't since the media queries don't match. Sure, this means a little bit of repetition in the styles, but eh, what can we do?
Some misc. tidbits: We should remove unused styles, to prevent rot. If unused, but the intent is to re-use it soon, adding a comment stating so would be helpful. (Please call me out on it if I do it!) No actionable elements should have an empty body! Right now this link is just empty if there is a lack of styles, or a lack of sight! It seems there was an issue with image replacement stemming form the way LESS applies This allows us to define the image replacement strictly for the proper media queries. But why is the Finally, it'd be better to include this as part of the main navigation. It's weird to have an option that's not available for narrow viewports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it works
@samueldr thank you for all the explanation. Agree with your decisions on every point. |
fixes #545
This change is