Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "syncthing: pin to go 1.14" #98690

Merged
merged 1 commit into from Sep 25, 2020
Merged

Revert "syncthing: pin to go 1.14" #98690

merged 1 commit into from Sep 25, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Sep 24, 2020

This reverts commit 384e56b.

Fixed in the 1.9.0 release.
https://github.com/syncthing/syncthing/releases/tag/v1.9.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor Author

zowoq commented Sep 25, 2020

@ofborg build syncthing.tests

@zowoq zowoq merged commit dc19de6 into NixOS:master Sep 25, 2020
@zowoq zowoq deleted the syncthing branch September 25, 2020 05:42
@mdevlamynck
Copy link
Contributor

Should this be backported to 20.09 because of #113054 ?

@ajs124
Copy link
Member

ajs124 commented Feb 20, 2021

The syncthing release on 20.09 is too old, we can backport the syncthing updates, but idk if we just want to pick 1.9.0 or all the way up to current. See #113809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @mdevlamynck @ajs124