Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zombietrackergps: init at 1.01 #98689

Merged
merged 2 commits into from Oct 10, 2020
Merged

zombietrackergps: init at 1.01 #98689

merged 2 commits into from Oct 10, 2020

Conversation

Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Sep 24, 2020

Motivation for this change

Closes #97065

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

0x4A6F
0x4A6F approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package build on x86_64
  • executables tested on x86_64
2 packages built:
ldutils zombietrackergps
Comments

Stumbled upon problem described in eb6ac6a during testing, but otherwise it runs fine.

veprbl
veprbl reviewed Oct 9, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ldutils/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Sohalt
Copy link
Contributor Author

Sohalt commented Oct 9, 2020

@veprbl thanks for the review!

@veprbl veprbl merged commit e96fd6e into NixOS:master Oct 10, 2020
sikmir
sikmir reviewed Oct 10, 2020
View reviewed changes
pkgs/development/libraries/ldutils/default.nix

meta = with lib; {
description = "Headers and link library for other ldutils projects";
homepage = "https://gitlab.com/ldutils-projects/ldutils";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.zombietrackergps.net/ztgps/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@veprbl veprbl veprbl approved these changes

@0x4A6F 0x4A6F 0x4A6F approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging request: ZombieTrackerGPS
4 participants
@Sohalt @veprbl @sikmir @0x4A6F