pythonPackages.datatable: 0.10.1 -> 0.11.0, fix build #98688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
suggested changes
Sep 27, 2020
risicle
force-pushed
the
ris-datatable-0.11.0
branch
2 times, most recently
from
2058dda
to
4578cab
Compare
once we've made some alterations to the source (which doesn't seem to have been shipped in a ready-to-build state), we can use the funny custom build system to build a wheel which can then be installed by the pipInstallHook. running the tests is again annoying because an ini file setting pytest's python_files parameter is missing, meaning we have to inject our own.
risicle
force-pushed
the
ris-datatable-0.11.0
branch
from
4578cab
to
33f1c60
Compare
jonringer
approved these changes
Sep 27, 2020
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/98688
1 package failed to build:
python37Packages.optuna
6 packages built:
python37Packages.dask-xgboost python37Packages.datatable python37Packages.xgboost python38Packages.dask-xgboost python38Packages.datatable python38Packages.xgboost
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF: #97479
I thought giving
datatablea bump might have been a short cut to getting it building again - how wrong was I? It looks like it's switched to a new build system and quite a few tweaks needed to be made.Once we've made some alterations to the source (which doesn't seem to have been shipped in a ready-to-build state), we can use the funny custom build system to build a wheel which can then be installed by the
pipInstallHook.Running the tests is again annoying because an ini file setting pytest's
python_filesparameter is missing, meaning we have to inject our own.Finally I had to fix it up for macos, which luckily only involved adding a manual header path, but meant I could get rid of a bunch of patchery and other cruft.
Have not tested all subsequent rebuilds, but it's late.Now I have and the only failure I get ispython37Packages.optunaon x86_64 linux (which seems to be akeras/tensorflowissue?)Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)