Fix shebang for binaries in JRuby #98693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzakaria
force-pushed
the
jruby-shebang-fix
branch
from
fa1798f
to
a3d0898
Compare
|
Result of 1 package built:- jruby |
There are a variety of additional scripts that are included with the JRuby installation that use JRuby itself. For instance the `bin/gem` had the following contents: ```bash ❯ cat /nix/store/kglkqf56ii83yl6yrgcaj5r3s9m2fzr0-jruby-9.2.13.0/bin/gem load File.join(File.dirname(__FILE__), 'jgem') ``` This is clearly wrong. Patchshebangs was not picking up the fix as part of stdenv because the patch is not a build input but the final output itself. We have to rely on substituteInPlace so that we get the correct version. ```bash ❯ cat /nix/store/k4fnrn0dcsh2wzw81217r0ywsspb468f-jruby-9.2.13.0/bin/gem ```
fzakaria
force-pushed
the
jruby-shebang-fix
branch
from
a3d0898
to
8da7bd6
Compare
fzakaria
commented
Sep 25, 2020
Comment on lines
+43
to
+45
| postFixup = '' | ||
| PATH=$out/bin:$PATH patchShebangs $out/bin | ||
| ''; |
|
Result of 1 package built:
|
|
backport: e703709 |
fzakaria
pushed a commit
to fzakaria/nixpkgs
that referenced
this pull request
Sep 27, 2020
Fix shebang for binaries in JRuby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There are a variety of additional scripts that are included with the
JRuby installation that use JRuby itself.
For instance the
bin/gemhad the following contents:This is clearly wrong. Patchshebangs was not picking up the fix as part
of stdenv because the patch is not a build input but the final output
itself.
Things done
We have to rely on patchShebangs but with a modified $PATH.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)CC @volth @mimame @asppsa @zimbatm (tagged a few people who've modified the file)