Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles: add HP Smart Array RAID scsi driver to all-hardware.nix #98633

Merged
merged 1 commit into from Dec 1, 2022
Merged

profiles: add HP Smart Array RAID scsi driver to all-hardware.nix #98633

merged 1 commit into from Dec 1, 2022

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented Sep 24, 2020

This adds support for HP Smart Array RAID controllers to all-hardware.nix

Motivation for this change

I couldn't boot hte nixos installer iso via the HP ILO interface of an HP server. Also flashing the ISO to one of it's internal SSDs and booting from there didn't work.
With other distros like debian this was not an issue.

Things done

Added the kernel module 'hpsa' to boot.initrd.availableKernelModules of all-hardware.nix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/367

@InLaw
Copy link
Contributor

InLaw commented Mar 28, 2021

Result of nixpkgs-review pr 98633 1

@stale
Copy link

stale bot commented Sep 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 26, 2021
@RaitoBezarius RaitoBezarius merged commit ec54537 into NixOS:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DavHau @nixos-discourse @InLaw @RaitoBezarius