support multiple major version of go package #98632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can also symbolic link the dependencies in build phrase? should improve build time. |
This seems semantically more correct
Mic92
reviewed
Sep 25, 2020
| unpackFile "${main}" | ||
| '' + lib.flip lib.concatMapStrings otherMajorVersions (drv: '' | ||
| mkdir ./${drv.majorVersion} | ||
| pushd ./${drv.majorVersion} |
There was a problem hiding this comment.
Sorry I just took the liberty to push my untested changes, since I don't have an example to test this and the time to find one. But this variant seems to be closer to your intention. If not, feel free to revert or adapt the last commit that I made.
my previous commit removed it, but I guess it is used after all
Mic92
reviewed
Sep 25, 2020
| combined = stdenv.mkDerivation { | ||
| inherit (main) name; | ||
|
|
||
| unpackCmd = "cp -r $curSrc/* ./"; |
There was a problem hiding this comment.
Since you override the behavior of unpackFile here, would it not more readable to just inline the cp command to make it easier to read?
|
successor: #98903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #98604