Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] firefox: 80.0 -> 81.0, firefox-bin: 79.0 -> 81.0, firefox-esr: 78.2.0esr -> 78.3.0esr #98650

Merged
merged 7 commits into from Sep 25, 2020
Merged

[20.03] firefox: 80.0 -> 81.0, firefox-bin: 79.0 -> 81.0, firefox-esr: 78.2.0esr -> 78.3.0esr #98650

merged 7 commits into from Sep 25, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Sep 24, 2020

Motivation for this change

#98469 for 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

taku0 and others added 4 commits September 24, 2020 22:19
@taku0
firefox-esr: 78.2.0esr -> 78.3.0esr
75c850d 
(cherry picked from commit 2460e0e)
@Atemu @taku0
firefox-bin: 79.0 -> 80.0 (NixOS#96279)
3bbe4c8 
(cherry picked from commit b12ca07)
@stigtsp @taku0
firefox-bin: 80.0 -> 80.0.1
9703bb2 
(cherry picked from commit 197799c)
@taku0
firefox-bin: 80.0.1 -> 81.0
9515a37 
(cherry picked from commit 3ad81fd)
@ofborg ofborg bot requested review from edolstra and andir September 24, 2020 14:08
@andir
Copy link
Member

andir commented Sep 25, 2020 •
edited

When building firefox on this PR I get:

 0:08.69(B ERROR: Requested 'nss >= 3.56' but version of NSS is 3.55.0(B
 0:08.73(B *** Fix above errors and then restart with\(B
 0:08.73(B                "./mach build"(B
 0:08.73(B make: *** [client.mk:115: configure] Error 1(B

@andir andir self-assigned this Sep 25, 2020
andir and others added 3 commits September 25, 2020 16:58
@andir andir merged commit 7587228 into NixOS:release-20.03 Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees

@andir andir

Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @andir @stigtsp @Atemu