New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.fs: fix tests on darwin #98619
Conversation
Running macos 10.14, I have a suspicion that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, WFM, LGTM on macos 10.14 & linux x86_64.
@risicle you should be able to see that "builder for '......drv' failed" if you pass the drv path to unless you're running these on a remote machine, then that's a little more complicated, but do-able |
Oh, I've closed the tab now... |
@jonringer @risicle Ready to merge or do you want me to change something? |
I think it's fine 👍 |
Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits. This can be done without
However, |
Refactors to pytestCheckHook and removes unused nose dependency.
ce90580
to
66afda2
Compare
@jonringer I rebased and fixuped the last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still WFM macos 10.14, non-nixos linux x86_64.
You have merge rights yourself so I'll let you do the honors.
@risicle I guess you are talking to @jonringer because I don't have merge rights as far as I know😄. |
You appear to be a "Member". Is there no big green merge button for you? |
@risicle: Nope, I only see: Only those with write access to this repository can merge pull requests.. What is needed to get merge right access? |
Lord knows, I think some drunk fool gave it to me |
@risicle member just means that you belong to a group within the NixOS (github) organization. Doesn't determine repo privileges |
Refactors to
pytestCheckHook
and removes unusednose
dependency.Motivation for this change
ZHF: #97479
@NixOS/nixos-release-managers
On darwin and python 3.8.5 there seems to be a problem. See PyFilesystem/pyfilesystem2#430
So I just disabled the failing test for now.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)