Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.fs: fix tests on darwin #98619

Merged
merged 1 commit into from Oct 7, 2020

Conversation

tricktron
Copy link
Member

Refactors to pytestCheckHook and removes unused nose dependency.

Motivation for this change

ZHF: #97479
@NixOS/nixos-release-managers

On darwin and python 3.8.5 there seems to be a problem. See PyFilesystem/pyfilesystem2#430

So I just disabled the failing test for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 25, 2020

Running macos 10.14, I have a suspicion that tests/test_tarfs.py::TestWriteGZippedTarFS::test_getinfo may be flakey. I got a single failure on python37Packages.fs but afterwards it built fine. Unfortunately I didn't get a full log for the failed build (all I can say is it was an AssertionError) because I expected to be able to reproduce it.

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, WFM, LGTM on macos 10.14 & linux x86_64.

@jonringer
Copy link
Contributor

@risicle you should be able to see that "builder for '......drv' failed" if you pass the drv path to nix log it will show you the build logs.

unless you're running these on a remote machine, then that's a little more complicated, but do-able

@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

Oh, I've closed the tab now...

@tricktron
Copy link
Member Author

@jonringer @risicle Ready to merge or do you want me to change something?

@risicle
Copy link
Contributor

risicle commented Sep 27, 2020

I think it's fine 👍

@jonringer
Copy link
Contributor

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done without git rebase -i by doing:

git reset HEAD~1                    # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

However, git rebase -i is a more powerful alternative, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

Refactors to pytestCheckHook and removes unused nose dependency.
@tricktron
Copy link
Member Author

@jonringer I rebased and fixuped the last commit.

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still WFM macos 10.14, non-nixos linux x86_64.

You have merge rights yourself so I'll let you do the honors.

@tricktron
Copy link
Member Author

@risicle I guess you are talking to @jonringer because I don't have merge rights as far as I know😄.

@risicle
Copy link
Contributor

risicle commented Oct 7, 2020

You appear to be a "Member". Is there no big green merge button for you?

@tricktron
Copy link
Member Author

You appear to be a "Member". Is there no big green merge button for you?

@risicle: Nope, I only see: Only those with write access to this repository can merge pull requests.. What is needed to get merge right access?

@risicle
Copy link
Contributor

risicle commented Oct 7, 2020

Lord knows, I think some drunk fool gave it to me

@risicle risicle merged commit f6af626 into NixOS:master Oct 7, 2020
@tricktron tricktron deleted the fix-fs-darwin branch October 8, 2020 05:03
@jonringer
Copy link
Contributor

@risicle member just means that you belong to a group within the NixOS (github) organization. Doesn't determine repo privileges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants