Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/ncdns: more tests and disable DNSSEC #98620

Merged
merged 1 commit into from Sep 25, 2020
Merged

nixos/tests/ncdns: more tests and disable DNSSEC #98620

merged 1 commit into from Sep 25, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 24, 2020

Motivation for this change

Fix the failing nixosTests.ncdns test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test (nixosTests.ncdns)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 25, 2020

@GrahamcOfBorg test ncdns

@rnhmjoj
nixos/tests/ncdns: more tests and disable DNSSEC
d7ae8ab 
- DNSSEC is currently disable because it's failing
- Separately test .bit domain on ncdns and pdns-recursor
- Test for the SOA record of the bit. zone
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 25, 2020

@GrahamcOfBorg test ncdns

@rnhmjoj rnhmjoj merged commit a0563de into NixOS:master Sep 25, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 27, 2020

Backported to 20.09 in be95370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rnhmjoj