Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] notebook: fix tests on darwin, 6.1.3 -> 6.1.4 #98621

Merged
merged 1 commit into from Sep 27, 2020
Merged

[20.09] notebook: fix tests on darwin, 6.1.3 -> 6.1.4 #98621

merged 1 commit into from Sep 27, 2020

Conversation

tricktron
Copy link
Member

Motivation for this change

Backport of: 2030061

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

WFM macos 10.14, linux x86_64 - only downstream build failures are already failing.

@tricktron tricktron mentioned this pull request Sep 26, 2020
Closed
@jonringer
Copy link
Contributor

commit message should have been:

pythonPackages.notebook: <original message>

but I'll just merge so that the two reflect the same commit message

@tricktron
Copy link
Member Author

@jonringer You are right, sorry about that.

@jonringer jonringer merged commit 188915b into NixOS:release-20.09 Sep 27, 2020
@tricktron tricktron deleted the backport-notebook branch September 27, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tricktron @risicle @jonringer