Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Set CMAKE_BUILD_TYPE to default to debug if not otherwise set #8315

Merged
merged 1 commit into from Sep 25, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Sep 24, 2020

Caused some issues where "not debug" != "release"

Happy to have my mind changed about whether the default should be Debug or Release

@glx22
Copy link
Contributor

glx22 commented Sep 25, 2020

I should probably check "visual studio" generator

Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC always set CMAKE_BUILD_TYPE when calling cmake command and defaults to Debug.
And I checked using Visual Studio generator still works.

@LordAro LordAro merged commit 85ca1c5 into OpenTTD:master Sep 25, 2020
@LordAro LordAro deleted the cmake-fortify-source-again branch September 25, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants