New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wtf: 0.31.0 -> 0.32.0 #98622
wtf: 0.31.0 -> 0.32.0 #98622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build OK on x64 linux
, but build FAILS on x64 darwin
:
go: downloading github.com/huandu/xstrings v1.2.0
go: downloading github.com/fatih/color v1.7.0
go: downloading github.com/mndrix/tap-go v0.0.0-20170113192335-56cca451570b
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d
installing
hash mismatch in fixed-output derivation '/nix/store/cbn96y1r2h21a9zrsrr1ffgm25nlbcgg-wtf-0.32.0-go-modules':
wanted: sha256:0l1q29mdb13ir7n1x65jfnrmy1lamlsa6hm2jagf6yjbm6wf1kw4
got: sha256:0p4cy7snxkx5in7c0nsy6bm0f1gn297rzwalm5rdfvhgdlb102nw
cannot build derivation '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hfkjz60aksbgy7x9xmrbbbi30rjmzmp7-wtf-0.32.0.drv' failed
Do you know why this happens? Is package resolution platform dependent in Go? |
I have no idea whether this is the right thing to do (it feels wrong...), but I changed the vendor SHA based on the platform. |
I'm not that experienced with Go, so unsure myself. But I share your feeling that it seems wrong. |
Here's the list of go modules which are downloaded when building the go-modules derivation on x64 (from https://logs.nix.ci/?attempt_id=e585fe01-1c04-49e1-aa92-1f99613dedb6&key=nixos%2Fnixpkgs.98622):
@stigok Do you have the list for Darwin at hand? Are there any differences? |
@aanderse can you trigger a darwin build for this PR? |
The order of the output is different, but content is the same when sorted. Build output from Darwin (the previous commit):
|
@GrahamcOfBorg build wtf |
I guess it got stuck and we can call this a failure?! What next? |
f7e76d1 is failing to build for me on
|
Done. I also removed the conditional vendor sha256 computation again and force pushed to the branch, original branch still available here. |
@avdv The commit message on b3fc088 doesn't match CONTRIBUTING.md#submitting-changes, either update the commit message to something like |
* mark as broken on darwin ``` these derivations will be built: /nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv building '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv'... unpacking sources unpacking source archive /nix/store/7xd1c92n7i0pcpxb71qgfz7d0hasbcrf-source source root is source patching sources configuring building Building subPackage ./. modules/azuredevops/widget.go:7:2: cannot find package "." in: /private/var/folders/hk/77b9kbln51v8hgc1c6j767k00000gn/T/nix-build-wtf-0.32.0.drv-0/source/vendor/github.com/microsoft/azure-devops-go-api/azuredevops modules/azuredevops/client.go:7:2: cannot find package "." in: /private/var/folders/hk/77b9kbln51v8hgc1c6j767k00000gn/T/nix-build-wtf-0.32.0.drv-0/source/vendor/github.com/microsoft/azure-devops-go-api/azuredevops/build builder for '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv' failed with exit code 1 error: build of '/nix/store/f29hm2393h56xh4slil62zlb72j5k0nq-wtf-0.32.0.drv' failed ```
@GrahamcOfBorg build wtf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing all the nitpicks :-)
Result of nixpkgs-review pr 98622
1
1 package built:
- wtf
Semi-automatic update generated by nixpkgs-update tools.
meta.description for wtf is: "The personal information dashboard for your terminal"
meta.homepage for wtf is: "https://wtfutil.com/"
meta.changelog for wtf is: ""
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests
, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 0.32.0 with grep in /nix/store/33ky4cyrz4qwzwcax2zmz9zz118gl3ll-wtf-0.32.0
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
11 package built:
Maintainer pings
cc @kalbasit @kalbasit for testing.