New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wargus: init at 2.4.3 #98665
wargus: init at 2.4.3 #98665
Conversation
Result of 1 package built:
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch) Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than that LGTM
pkgs/games/wargus/default.nix
Outdated
{ stdenv, callPackage, fetchFromGitHub | ||
, cmake, pkg-config, makeWrapper | ||
, zlib, bzip2, libpng | ||
, dialog, python, cdparanoia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be python 2 or 3? I think we should set this explicit just to make it clear.
@astro can you address the last comment? |
Ok, updated and rebased. Thanks for the nudge. |
Result of 1 package built:
|
It seem to generally work:
a dialog dependency could get added in a later pr. i can't test it with the actual data. @astro have you done that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM
Builds, seem to generally run
Yes, I have used the Wargus scripts to convert the game data and then I played a few epic battles. |
Motivation for this change
Warcraft2
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)