Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-sync-readme: init at 1.0 #68670

Merged
merged 1 commit into from Sep 24, 2020
Merged

cargo-sync-readme: init at 1.0 #68670

merged 1 commit into from Sep 24, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n B4dM4n changed the title cargo-sync-readme: init at 0.2.1 cargo-sync-readme: init at 1.0 May 30, 2020
@typetetris
Copy link
Contributor

Result of nixpkgs-review pr 68670 1

1 package built:
- cargo-sync-readme

typetetris
typetetris reviewed Jul 19, 2020
View reviewed changes
Copy link
Contributor

@typetetris typetetris left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on linux x86_64
  • executables tested on linux x86_64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected

One point:

  1. would suggest placing this in pkgs/development/tools/rust/cargo-sync-readme

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Jul 30, 2020

  1. would suggest placing this in pkgs/development/tools/rust/cargo-sync-readme

Fair point.

I moved the package to the suggested location.

@ryantm ryantm merged commit 5b61492 into NixOS:master Sep 24, 2020
@ryantm
Copy link
Member

ryantm commented Sep 24, 2020

@typetetris super helpful review thanks.

@B4dM4n B4dM4n deleted the cargo-sync-readme branch September 24, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typetetris typetetris typetetris left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @typetetris @ryantm