Fix functionArgs for primops #4062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both functions and primops have `builtins.typeOf v == "lambda"`, and
they also both return true for `builtins.isFunction`, yet
`builtins.functionArgs` fails for primops without this change:
$ nix-instantiate --eval -E 'builtins.isFunction builtins.add'
true
$ nix-instantiate --eval -E 'builtins.functionArgs builtins.add'
error: 'functionArgs' requires a function, at (string):1:1
For simplicity, primops aren't assumed to have named function arguments,
which is correct for most of them, so `builtins.functionArgs` now just
returns `{}` for all of them
|
This looks similar to #3626. There was some discussion there about whether this is a good idea. |
|
Oh yeah this is actually the very same change, I'll direct my comments to the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both functions and primops have
builtins.typeOf v == "lambda", and they also both return true forbuiltins.isFunction, yetbuiltins.functionArgsfails for primops without this change:For simplicity, primops aren't assumed to have named function arguments, which is correct for most of them, so
builtins.functionArgsnow just returns{}for all of them