Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plexamp: 3.1.1 -> 3.2.0 #98682

Merged
merged 1 commit into from Sep 24, 2020
Merged

plexamp: 3.1.1 -> 3.2.0 #98682

merged 1 commit into from Sep 24, 2020

Conversation

afontaine
Copy link
Contributor

@afontaine afontaine commented Sep 24, 2020 •
edited

Motivation for this change

Adds remote control support for other plex players, as well as other
changes.

Release notes: https://forums.plex.tv/t/plexamp-release-notes/221280/16

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@afontaine
plexamp: 3.1.1 -> 3.2.0
73133a6 
Adds remote control support for other plex players, as well as other
changes.

Release notes: https://forums.plex.tv/t/plexamp-release-notes/221280/16
@zimbatm
Copy link
Member

zimbatm commented Sep 24, 2020

Result of nixpkgs-review pr 98682 1

1 package built:
  • plexamp

@zimbatm zimbatm merged commit 55e2c83 into NixOS:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afontaine @zimbatm