Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.lsp_extensions-nvim: init at 2020-09-06 #98667

Merged
merged 2 commits into from Sep 24, 2020
Merged

vimPlugins.lsp_extensions-nvim: init at 2020-09-06 #98667

merged 2 commits into from Sep 24, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Sep 24, 2020

Motivation for this change

After reading Neovim and Rust from @sharksforarms, I figured I should try rust-analyzer with the new (and unreleased) nvim-lsp client.

As noted in the post, type inlay hints require the lsp_extensions package.

They seem to work as intended after I rebuild my nvim configuration with the relevant changes required to enable rust-analyzer and various settings for such.
image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

49 packages built:
  • vimPlugins.Spacegray-vim
  • vimPlugins.Syntastic (vimPlugins.syntastic)
  • vimPlugins.Tagbar (vimPlugins.tagbar)
  • vimPlugins.YouCompleteMe
  • vimPlugins.clang_complete
  • vimPlugins.coc-explorer
  • vimPlugins.coc-nvim
  • vimPlugins.completion-nvim
  • vimPlugins.conjure
  • vimPlugins.ctrlp (vimPlugins.ctrlp-vim)
  • vimPlugins.defx-nvim
  • vimPlugins.denite (vimPlugins.denite-nvim)
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-lsp
  • vimPlugins.elm-vim
  • vimPlugins.fugitive (vimPlugins.vim-fugitive)
  • vimPlugins.hoon-vim
  • vimPlugins.lsp_extensions-nvim
  • vimPlugins.maktaba (vimPlugins.vim-maktaba)
  • vimPlugins.neoformat
  • vimPlugins.neosnippet-snippets
  • vimPlugins.neoterm
  • vimPlugins.nerdtree-git-plugin
  • vimPlugins.nvim-treesitter
  • vimPlugins.polyglot (vimPlugins.vim-polyglot)
  • vimPlugins.rust-vim
  • vimPlugins.sideways-vim
  • vimPlugins.splitjoin-vim
  • vimPlugins.tmuxNavigator (vimPlugins.tmux-navigator ,vimPlugins.vim-tmux-navigator)
  • vimPlugins.vim-bazel
  • vimPlugins.vim-clap
  • vimPlugins.vim-codefmt
  • vimPlugins.vim-fireplace
  • vimPlugins.vim-gista
  • vimPlugins.vim-go
  • vimPlugins.vim-lsc
  • vimPlugins.vim-lsp
  • vimPlugins.vim-osc52
  • vimPlugins.vim-rooter
  • vimPlugins.vim-salve
  • vimPlugins.vim-snippets
  • vimPlugins.vim-terraform
  • vimPlugins.vim-visual-multi
  • vimPlugins.vim-vsnip
  • vimPlugins.vim-which-key
  • vimPlugins.vimspector
  • vimPlugins.vimtex
  • vimPlugins.vista-vim
  • vimPlugins.zig-vim

@ofborg ofborg bot requested review from jagajaga and jorsn September 24, 2020 18:00
@teto teto merged commit 04ecdc6 into NixOS:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@timokau timokau Awaiting requested review from timokau

@marsam marsam Awaiting requested review from marsam

@jagajaga jagajaga Awaiting requested review from jagajaga

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evanjs @teto