doc/nixos: Explain better NixOS specific Systemd stuff #98661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
reviewed
Sep 25, 2020
rnhmjoj
reviewed
Sep 27, 2020
doronbehar
force-pushed
the
doc/nixos/systemd-nixos-specific
branch
from
fb4cb38
to
b4ff865
Compare
doronbehar
force-pushed
the
doc/nixos/systemd-nixos-specific
branch
from
b4ff865
to
6d9abdb
Compare
doronbehar
force-pushed
the
doc/nixos/systemd-nixos-specific
branch
from
6d9abdb
to
4889fb3
Compare
|
I don't think there's anything more important to add and I think it's better to have this then nothing. Fixed the systemd spelling. |
rnhmjoj
reviewed
Nov 5, 2020
rnhmjoj
requested changes
Nov 5, 2020
Divide the "Service Management" chapter into two sections. The 1st (the original) explaining General, not NixOS specific ways to interact with Systemd. The 2nd section, explaining NixOS specific things worth knowing. Explain in the 2nd section a bit NixOS modules and services of Nixpkgs, and mention `systemd.user.services` option. Give an example demonstrating how to enable imperatively an upstream provided unit file for a user. Explain why `systemctl --user enable` doesn't work for the long term on NixOS.
doronbehar
force-pushed
the
doc/nixos/systemd-nixos-specific
branch
from
4889fb3
to
8716b71
Compare
Great. I fixed the typo and made sure it builds. Will wait for your final approval. |
rnhmjoj
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide the "Service Management" chapter into two sections. The 1st (the
original) explaining General, not NixOS specific ways to interact with
Systemd. The 2nd section, explaining NixOS specific things worth
knowing.
Explain in the 2nd section a bit NixOS modules and services of Nixpkgs,
and mention
systemd.user.servicesoption. Give an exampledemonstrating how to enable imperatively an upstream provided unit file
for a user. Explain why
systemctl --user enabledoesn't work for thelong term on NixOS.
Motivation for this change
My own confusion regarding the subject + https://discourse.nixos.org/t/how-to-enable-upstream-systemd-user-services-declaratively/7649/5 .
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)