Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3.pkgs.pysdl2: fix build #98678

Merged
merged 1 commit into from Sep 25, 2020
Merged

[20.09] python3.pkgs.pysdl2: fix build #98678

merged 1 commit into from Sep 25, 2020

Conversation

povik
Copy link
Contributor

@povik povik commented Sep 24, 2020

Update patches after version bump.

(cherry picked from commit c3066d3)

Backport of #98300
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@povik
python3.pkgs.pysdl2: fix build
b3db371 
Update patches after version bump.

(cherry picked from commit d82e165)
@povik
Copy link
Contributor Author

povik commented Sep 24, 2020

Changed to cherry-picking the actual commit from master.

@ofborg ofborg bot requested a review from pmiddend September 24, 2020 20:57
@risicle
Copy link
Contributor

risicle commented Sep 25, 2020 •
edited

WFM linux x86_64, macos 10.14, LGTM

@risicle risicle merged commit 0ed8c8f into NixOS:release-20.09 Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@pmiddend pmiddend Awaiting requested review from pmiddend

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@povik @risicle