Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elixir_1_6: remove #98649

Merged
merged 1 commit into from Sep 24, 2020
Merged

elixir_1_6: remove #98649

merged 1 commit into from Sep 24, 2020

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Sep 24, 2020 •
edited

Additionally removed the now obsolete rebar build dependency for elixir.
Was only necessary till v1.6.

Motivation for this change

As Elixir v1.11 will be released soon - Elixir v1.6 will then be deprecated.
But my main motivation to do it now is to get rid of the rebar build dependency.
It seems that rebar won't build with Erlang v23 anymore.
Erlang v23.1 is already released and in my opinion should get soon the default Erlang version within nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cw789
elixir_1_6: remove
3c379af 
Additionally removed the now obsolete rebar build dependency for elixir.
@zimbatm
Copy link
Member

zimbatm commented Sep 24, 2020

Result of nixpkgs-review pr 98649 1

5 packages built:
  • elixir (elixir_1_10)
  • elixir_1_7
  • elixir_1_8
  • elixir_1_9
  • rabbitmq-server

@zimbatm zimbatm merged commit cc9b34a into NixOS:master Sep 24, 2020
@cw789 cw789 deleted the elixir_cleanup branch September 25, 2020 07:01
@DianaOlympos
Copy link
Contributor

Hello, so i got hit today by the fact that on nixos-20.09 we allow erlang 23, but also have not put this patch in nixos-20.09. and rebar does not compile for all kind of broken reasons

Would it be possible to merge this in 20.09 too. I know it means we lose 1.6 which would need a patchnote, but this is an old version not supported anymore and this break everyone trying to run elixir on otp23 on 20.09, which we allowed

@DianaOlympos DianaOlympos mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@ankhers ankhers Awaiting requested review from ankhers

@couchemar couchemar Awaiting requested review from couchemar

Assignees
No one assigned
Labels
6.topic: erlang 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cw789 @zimbatm @DianaOlympos