Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iptraf: mark as broken #99087

Merged
merged 1 commit into from Sep 29, 2020
Merged

iptraf: mark as broken #99087

merged 1 commit into from Sep 29, 2020

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

Required headers have been removed from the linux kernel, the original project is pretty much unmaintained, see also iptraf-ng as an potential alternative.

Build fails, see https://hydra.nixos.org/build/127639950

Should be backported to 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elohmeier
Copy link
Contributor Author

Backported in #99089

@elohmeier
Copy link
Contributor Author

Fixed typo.

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 29, 2020
jonringer
jonringer approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99087 1

@jonringer jonringer merged commit 5b65d3e into NixOS:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elohmeier @jonringer