Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-corporal: init at 2.0.1 #99074

Merged
merged 2 commits into from Jan 17, 2021
Merged

matrix-corporal: init at 2.0.1 #99074

merged 2 commits into from Jan 17, 2021

Conversation

dali99
Copy link
Member

@dali99 dali99 commented Sep 29, 2020

Motivation for this change

matrix-corporal is a proxy and reconciliator for matrix-synapse letting you allow/deny API endpoints, and automatically join users to rooms/communities according to a configuration policy

Things done

Only adds a package, I might make a module in the future, but settings and secrets was a little hard in #93777

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit September 29, 2020 07:54
@dali99
Copy link
Member Author

dali99 commented Sep 30, 2020 •
edited

@Ma27 @aanderse from the last PR

@aanderse
Copy link
Member

aanderse commented Oct 1, 2020

I only ever reviewed the NixOS module and not the package... Sorry I don't have more to offer ☹️

@Ma27
Copy link
Member

Ma27 commented Oct 1, 2020

Wouldn't it make sense to add a module as well though?

@dali99
Copy link
Member Author

dali99 commented Oct 1, 2020

It would, but when I asked for help with the secrets I was just pointed to an upcoming systemd feature. Which might help in the future and it's definitely very good that the situation will improve! But it didn't give me anything actionable to do.

In the meantime this package along with a systemd service is what I've been using :/

@infinisil
Copy link
Member

Build works, but running it I get:

---------------------------------------------------------- [ Version:  ]
GitCommit:
GitBranch:
GitState:
GitSummary:
BuildDate:

I think it would be a good idea to try to make sure this includes at least the git commit and/or version (not the build date though, because that's impure).

@SuperSandro2000
Copy link
Member

@dali99 please address the review feedback.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99074 run on x86_64-linux 1

1 package built:
  • matrix-corporal

@dali99 dali99 changed the title matrix-corporal: init at 1.10.1 matrix-corporal: init at 2.0.0 Jan 17, 2021
@dali99
Copy link
Member Author

dali99 commented Jan 17, 2021

The package has been updated to 2.0.0 and now prints:

                 _        _                                                _
 _ __ ___   __ _| |_ _ __(_)_  __      ___ ___  _ __ _ __   ___  _ __ __ _| |
| '_ \ _ \ / _\ | __| '__| \ \/ /____ / __/ _ \| '__| '_ \ / _ \| '__/ _\ | |
| | | | | | (_| | |_| |  | |>  <_____| (_| (_) | |  | |_) | (_) | | | (_| | |
|_| |_| |_|\__,_|\__|_|  |_/_/\_\     \___\___/|_|  | .__/ \___/|_|  \__,_|_|
                                                    |_|
---------------------------------------------------------- [ Version: 2.0.0 ]
GitCommit: 2.0.0
GitBranch: 2.0.0
GitState: nixpkgs
GitSummary: 2.0.0
BuildDate:

Im not sure if that's what we want, and I took the liberty of using the GitState to say it is built with nixpkgs

@dali99 dali99 changed the title matrix-corporal: init at 2.0.0 matrix-corporal: init at 2.0.1 Jan 17, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 99074 run on x86_64-darwin 1

1 package built:
  • matrix-corporal

@SuperSandro2000 SuperSandro2000 merged commit 4095262 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dali99 @aanderse @Ma27 @infinisil @SuperSandro2000