Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.cartopy: 0.17 -> 0.18 #98210

Merged
merged 1 commit into from Sep 18, 2020
Merged

python3.pkgs.cartopy: 0.17 -> 0.18 #98210

merged 1 commit into from Sep 18, 2020

Conversation

povik
Copy link
Contributor

@povik povik commented Sep 18, 2020

Fixes build. Formerly cartopy tests were failing, likely since update of
matplotlib to 3.3.0.

I ran few usage examples (x86_64-linux) to verify the library is ok.

May fix build failure on darwin reported in #96864.
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@povik
python3.pkgs.cartopy: 0.17 -> 0.18
afc7d9f 
Fixes build. Formerly cartopy tests were failing, likely since update of
matplotlib to 3.3.0.
jonringer
jonringer approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98210 1

2 packages built:
  • python37Packages.cartopy
  • python38Packages.cartopy

@jonringer jonringer merged commit 2047252 into NixOS:master Sep 18, 2020
@povik povik mentioned this pull request Sep 18, 2020
Merged
10 tasks
@marsam marsam mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@povik @jonringer