Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniserve: 0.8.0 -> 0.9.0 #98181

Merged
merged 1 commit into from Sep 23, 2020
Merged

miniserve: 0.8.0 -> 0.9.0 #98181

merged 1 commit into from Sep 23, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Sep 17, 2020 •
edited

https://github.com/svenstaro/miniserve/releases/tag/v0.9.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Broken on darwin:

error: failed to run custom build command for `brotli-sys v0.3.2`

Edit: darwin failure seems to be specific to the darwin/rust toolchain in nixpkgs.

@ofborg ofborg bot requested a review from NeQuissimus September 17, 2020 21:40
@zowoq zowoq marked this pull request as ready for review September 23, 2020 10:04
@zowoq zowoq merged commit f9666eb into NixOS:master Sep 23, 2020
@zowoq zowoq deleted the miniserve branch September 23, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @NeQuissimus