haskellPackages.logging-effect: fix dependency resolution #98205
Conversation
| logging-effect = markUnbroken (super.logging-effect.override { | ||
| unliftio-core = super.unliftio-core_0_2_0_1; | ||
| }); |
There was a problem hiding this comment.
Is this for ZHF? If so, then it is basically fine as it is (assuming you will just commit straight to the release-20.09 branch).
If this isn't for ZHF, and you just want this fixed in master, can you do the following?
-
Change the base branch on github to
haskell-updates(and probably rebase onhaskell-updatesas well). -
Instead of using
markUnbrokenin this file, removelogging-effectfrom thebroken-packageslist inconfiguration-hackage2nix.nix.The
hackage-packages.nixfile gets regenerated daily on thehaskell-updatesbranch. Since you've removedlogging-effectfrom the list of broken packages, next timehackage-packages.nixis regenerated, it will be regenerated without thelogging-effectpackage havingbroken = true;.
There was a problem hiding this comment.
Not directly but it will help with ZHF and can be backported to 20.09.
Now that I have played with the patch more, I think a better solution is to pin the version to logging-effect ==1.3.10 because otherwise, it will not work with those other libraries.
There was a problem hiding this comment.
Will there be more updates to this pull request?
|
The solution is actually to downgrade logging-effect to v1.3.10. Overriding unliftio-core is problematic because other packages might be using the newer version. But I don't know enough of the haskell ecosystem to fix that. |
Motivation for this change
This probably fixes another 10 packages that depend on this library.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)