Revert "idle-detection: Implement requestPermission() method" #25611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 67a8dbc31af629c51d6661c1b1d6da4218258ad8. Reason for revert: https://crbug.com/1129639 Original change's description: > idle-detection: Implement requestPermission() method > > This change implements a static requestPermission() method on the > IdleDetector interface and switches the API from requiring the > "notifications" permission to the new "idle-detector" permission. > > Bug: 878979 > Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539 > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Ayu Ishii <ayui@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808019} TBR=reillyg@chromium.org,arthursonzogni@chromium.org,ayui@chromium.org Change-Id: I41401a81e0e75613340ebe8aa5665c3d1a45414c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417473 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#808208}
wpt-pr-bot
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 67a8dbc31af629c51d6661c1b1d6da4218258ad8.
Reason for revert: https://crbug.com/1129639
Original change's description:
TBR=reillyg@chromium.org,arthursonzogni@chromium.org,ayui@chromium.org
Change-Id: I41401a81e0e75613340ebe8aa5665c3d1a45414c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417473
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808208}