Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT] Test forcible worker termination (modules/dynamic imports) #25621

Merged
merged 1 commit into from Sep 24, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 18, 2020

This CL adds tests for forcible worker termination during:

  • Module top-level script evaluation,
  • Evaluation of dynamic import()ed script evaluation
    (from module/classic workers),

The failure of
"Worker is terminated during top-level script evaluation (module)"
test on Chromium is tracked by crbug.com/1129793.

Bug: 1111134, 1129785, 1129793
Change-Id: I7babf738848a2de51a62679e080a389519fd5884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418751
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810096}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WPT] Add forcible worker termination tests (modules and dynamic imports) [WPT] Test forcible worker termination (modules/dynamic imports/TLA) Sep 18, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2418751 branch 3 times, most recently from dd95bb0 to 4fe328e Compare September 18, 2020 13:32
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WPT] Test forcible worker termination (modules/dynamic imports/TLA) [WPT] Test forcible worker termination (modules/dynamic imports) Sep 19, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2418751 branch 2 times, most recently from 9245f62 to 85e2033 Compare September 24, 2020 02:44
This CL adds tests for forcible worker termination during:

- Module top-level script evaluation,
- Evaluation of dynamic import()ed script evaluation
  (from module/classic workers),

The failure of
"Worker is terminated during top-level script evaluation (module)"
test on Chromium is tracked by crbug.com/1129793.

Bug: 1111134, 1129785, 1129793
Change-Id: I7babf738848a2de51a62679e080a389519fd5884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418751
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810096}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants