Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.requests-aws4auth: fix build #98193

Merged
merged 1 commit into from Sep 18, 2020
Merged

python3Packages.requests-aws4auth: fix build #98193

merged 1 commit into from Sep 18, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 18, 2020

Motivation for this change

Fix build and get tests running for all python versions.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from basvandijk September 18, 2020 02:42
jonringer
jonringer approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98193 1

4 packages built:
  • elasticsearch-curator
  • python27Packages.requests-aws4auth
  • python37Packages.requests-aws4auth
  • python38Packages.requests-aws4auth

@jonringer jonringer merged commit 5f0f2b8 into NixOS:master Sep 18, 2020
@wkral wkral deleted the python-requests-aws4auth-fix branch May 15, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkral @jonringer