Fix clear-window-name.https.html fail message #25608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 17, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2416727
branch
2 times, most recently
from
e6b2870
to
6654cb1
Compare
This test produced different output every time it failed since a randomly generated string was being passed to assert_equals. This patch does the same check but prevents the generated string from getting into the error message so we can include it in our failing test expectations. Fixed: 1129420 Change-Id: I5cffb6c3dfbe7bb551a626780273291d732f6e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416727 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#808576}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2416727
branch
from
6654cb1
to
646b723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test produced different output every time it failed since a
randomly generated string was being passed to assert_equals. This patch
does the same check but prevents the generated string from getting into
the error message so we can include it in our failing test expectations.
Fixed: 1129420
Change-Id: I5cffb6c3dfbe7bb551a626780273291d732f6e1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416727
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808576}