solvespace-cli: Fix --view #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues solvespace#499. The --view option changes projUp and projRight. For --view to affect the camera, the camera needs to be initialized using these values.
|
I'm trying this on Linus (Fedora 32) and this doesn't seem to fix it. I get the same view regardless of which option I use after --view and I get the error message if no view direction is provided. Strange. I'm also seeing the ZoomToFit(camera) which is apparently not doing anything since my thumbnails are centered on the origin and my model is all in quadrant one. |
|
Disregard my previous comment, isometric works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #499. The --view option changes projUp and projRight. For --view to affect the camera, the camera needs to be initialized using these values.