Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI option "--view" has no effect on output thumbnail #499

Closed
ghost opened this issue Nov 2, 2019 · 3 comments · Fixed by #707
Closed

CLI option "--view" has no effect on output thumbnail #499

ghost opened this issue Nov 2, 2019 · 3 comments · Fixed by #707
Labels
bug
Milestone
3.0

Comments

@ghost
Copy link

ghost commented Nov 2, 2019 •
edited by ghost

System information

  • SolveSpace version: 3.0~5d78f993 (solvespace-cli)
  • Operating system: Debian 9.x stretch

Expected behavior

Changing --view option variable to top/bottom/left/right/front/back/isometric should change view for rendering thumbnail.

Actual behavior

I tried to generate thumbnail with --view isometric direction:

$ solvespace-cli thumbnail --output ./%-render.png --size 1280x800 --view isometric ./dt830b-case-top.slvs

But resulted image rendered in default SolveSpace view, e.g.:

projection onto screen:
  right  ( 1.000, 0.000, 0.000)  [edit]
  up     ( 0.000, 1.000, 0.000)
  out    ( 0.000, 0.000, 1.000)

Tried different --view variables, but result always is same.

Additional information

For bugs, please attach a savefile that shows the problematic behavior.
You can attach .slvs files by archiving them into a .zip first.
@whitequark whitequark added the bug label Nov 2, 2019
@ghost
Copy link
Author

ghost commented Nov 2, 2019 •
edited by ghost

As I understand, --view isometric (nearest isometric) projection should be something like:

projection onto screen:
  right  ( 0.707, 0.000, -0.707)  [edit]
  up     (-0.408, 0.816,-0.408)
  out    ( 0.577, 0.577, 0.577)

Is it possible add option «save as default isometric view» into «Properties Browser > view > projection onto screen:» (+ «load factory default» for reset) to save actual view as default variable of --view isometric projection?

@whitequark whitequark added this to the 3.0 milestone Jun 23, 2020
Christoph-D added a commit to Christoph-D/solvespace that referenced this issue Sep 18, 2020
@Christoph-D
solvespace-cli: Fix --view
4a73804 
This fixes issues solvespace#499. The --view option changes projUp and
projRight. For --view to affect the camera, the camera needs to be
initialized using these values.
@Christoph-D Christoph-D mentioned this issue Sep 18, 2020
Merged
phkahler pushed a commit that referenced this issue Sep 19, 2020
@Christoph-D @phkahler
solvespace-cli: Fix --view
34328c9 
This fixes issues #499. The --view option changes projUp and
projRight. For --view to affect the camera, the camera needs to be
initialized using these values.
@phkahler
Copy link
Member

I merged PR #706 but I don't think this issue is ready to close. It's not clear to me that the options top,bottom, etc... are producing the correct views and they are not always centred well. Isometric seems to work though.

What is the default view in SolveSpace? Is that considered "front"? Or is it "top"? or something else?

@phkahler
Copy link
Member

The camera offset in GraphicsWindow::ZoomToFit is still not centering the view correctly.

@phkahler phkahler mentioned this issue Sep 19, 2020
Merged
@phkahler phkahler linked a pull request Sep 19, 2020 that will close this issue
Fix view centering for cli thumbnail function. #707
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Fix view centering for cli thumbnail function. phkahler/solvespace
2 participants
@whitequark @phkahler