[mathml] Improve feature detection for operator dictionary test #25619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
fred-wang
changed the title
The operator dictionary test compare various properties with an explicit attribute set VS the default dictionary value. If the feature corresponding to that property is not supported, then the test will just return false positives. Feature detection was implemented for spacing and movablelimits. This commit implements the detection for the remaining properties (largeop, stretchy, symmetric). This requires a special test font and so only async feature detection functions are possible.
fred-wang
force-pushed
the
mathml-op-dict-feature-detect
branch
from
591b9d1
to
d09fa6e
Compare
ziransun
pushed a commit
to ziransun/wpt
that referenced
this pull request
Oct 6, 2020
…platform-tests#25619) * [mathml] Improve feature detection for operator dictionnary test The operator dictionary test compare various properties with an explicit attribute set VS the default dictionary value. If the feature corresponding to that property is not supported, then the test will just return false positives. Feature detection was implemented for spacing and movablelimits. This commit implements the detection for the remaining properties (largeop, stretchy, symmetric). This requires a special test font and so only async feature detection functions are possible. * move operator detection into a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator dictionary test compare various properties with an
explicit attribute set VS the default dictionary value. If the
feature corresponding to that property is not supported, then the
test will just return false positives. Feature detection was
implemented for spacing and movablelimits. This commit implements
the detection for the remaining properties (largeop, stretchy,
symmetric). This requires a special test font and so only
async feature detection functions are possible.