Add tests to validate XR compatible request scenarios that should throw #25604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 17, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2416856
branch
from
5e06993
to
2ccdebb
Compare
This change adds tests that validate scenarios where requesting XR compatibility should fail: - If the WebXR feature policy isn't allowed, a SecurityError is thrown - If there are no devices available, an InvalidStateError is thrown A runtime enabled feature is added for WebXR multi GPU that syncs with the corresponding Chromium feature flag. Bug: 1124024 Change-Id: Ia79b06ecffa936471a6fd80172717c7724245bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416856 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810288}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2416856
branch
from
2ccdebb
to
7e74ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds tests that validate scenarios where requesting XR
compatibility should fail:
A runtime enabled feature is added for WebXR multi GPU that syncs with
the corresponding Chromium feature flag.
Bug: 1124024
Change-Id: Ia79b06ecffa936471a6fd80172717c7724245bf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416856
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810288}