[LayoutShiftTracker] Fix contain:paint #25603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 17, 2020
We should check ShouldClipOverflow() instead of IsScrollContainer() (which was renamed from HasOverflowClip() recently -- this CL shows how the new name improved code readability) for inclusion of layout overflow for layout shift tracking. Bug: 1127474 Change-Id: Id85b292b65dae837d1e366d548939b85c9cd5d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417061 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808087}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2417061
branch
from
5488fc8
to
b47f5fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check ShouldClipOverflow() instead of IsScrollContainer()
(which was renamed from HasOverflowClip() recently -- this CL shows how
the new name improved code readability) for inclusion of layout overflow
for layout shift tracking.
Bug: 1127474
Change-Id: Id85b292b65dae837d1e366d548939b85c9cd5d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417061
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808087}