Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.irc: fix build #98232

Merged
merged 1 commit into from Sep 18, 2020
Merged

python3Packages.irc: fix build #98232

merged 1 commit into from Sep 18, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 18, 2020

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wkral
Copy link
Contributor Author

wkral commented Sep 18, 2020

Result of nixpkgs-review pr 98232 1

3 packages built:
  • errbot
  • python37Packages.irc
  • python38Packages.irc

@risicle
Copy link
Contributor

risicle commented Sep 18, 2020

You wouldn't mind adding a pythonImportsCheck = [ "irc" ] to this one would you? Seeing as it has no tests...

@wkral
Copy link
Contributor Author

wkral commented Sep 18, 2020

@risicle No problem, added it and squashed. I'll try to keep that in mind if I hit that again in some future fixes.

@risicle
Copy link
Contributor

risicle commented Sep 18, 2020

Thanks. It's not really your job, it's just a useful drive-by improvement that can be made.

WFM macos 10.14, linux x86_64

@risicle risicle merged commit b6c7026 into NixOS:master Sep 18, 2020
@wkral wkral deleted the py-irc-fix-build branch May 15, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkral @risicle