New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception safety with smart pointers #704

Closed

elfring opened this issue Sep 18, 2020 · 1 comment

elfring commented Sep 18, 2020

Would you like to wrap any pointer data members with the class template “std::unique_ptr”?

Update candidates:

Contributor

Christoph-D commented Sep 20, 2020

solvespace does not use exceptions: https://github.com/solvespace/solvespace/blob/master/CONTRIBUTING.md#exceptions
So purely from an exception safety point of view this change is unnecessary.

unique_ptr might still be useful for simplicity.

phkahler closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment