New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackage.binary-search: unbreak #98196
Conversation
@@ -235,7 +235,7 @@ self: super: { | |||
aws = dontCheck super.aws; # needs aws credentials | |||
aws-kinesis = dontCheck super.aws-kinesis; # needs aws credentials for testing | |||
binary-protocol = dontCheck super.binary-protocol; # http://hydra.cryp.to/build/499749/log/raw | |||
binary-search = dontCheck super.binary-search; | |||
binary-search = dontCheck (appendPatch super.binary-search ./patches/binary-search-1.0.0.3-ghc-8.8.patch); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anyway you can pull this patch from upstream? Normally we try to avoid carrying around patches here in nipxkgs if possible.
Check in this file for uses of fetchpatch
to see how this can be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping?
@@ -40405,7 +40405,6 @@ self: { | |||
description = "Binary and exponential searches"; | |||
license = stdenv.lib.licenses.bsd3; | |||
hydraPlatforms = stdenv.lib.platforms.none; | |||
broken = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be edited directly, but instead the - binary-search
line should be removed from the broken-packages
section of pkgs/development/haskell-modules/configuration-hackage2nix.nix
. Then binary-search
will automatically be marked as non-broken the next time pkgs/development/haskell-modules/hackage-packages.nix
is automatically regenerated.
One last small thing. In general, you should try to format commit messages as described in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md. So for this PR, the commit might look like:
(Or even something more descriptive.) |
659ff55
to
d0541e2
Compare
be2e4fb
to
1436509
Compare
d060d81
to
c90c206
Compare
87295a3
to
e240cce
Compare
82a05ac
to
7d050d4
Compare
0cf6d0c
to
c55cdb4
Compare
96ed039
to
4f2880b
Compare
Sorry, i wasn't active. I am making another branch since this is becoming a mess, is that ok? |
Motivation for this change
Fix broken haskell package "binary-search"
Things done
Created patch
Removed broken flag
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandbox
innix.conf
on non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in
./result/bin/
)Determined the impact on package closure size (by running
nix path-info -S
before and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
I will try and test with more of those parameters in the meantime